Dodaje wersje maxymalnie zoptymalizowana. Jesli chodzi o zapytania sql w aktualnej wersji (powyzej) do petli kolega dodal zapytanie wczytujace nazwe usera a co za tym idzie, ilosc zapytan do wykonania powieksza sie wraz z iloscia komentarzy danego newsa.
Problem ten rozwiazuje polaczenie tabel w jednym zapytaniu; dodatkowo zastosowalem rozwiazanie w przypadku potrzeby wyswietlania komentarzy w newsach jak i w artach bez potrzeby dodawania kolejnego kodu do czesci z artami a dziala to za pomoca wykorzystania zmienych globalnych z tablicy $_GET :D
Oto kod (pogrubieniem zaznaczone zmiany) plik print.php <?php
/*---------------------------------------------------+
| PHP-Fusion 6 Content Management System
+----------------------------------------------------+
| Copyright © 2002 - 2006 Nick Jones
| http://www.php-fusion.co.uk/
+----------------------------------------------------+
| Released under the terms & conditions of v2 of the
| GNU General Public License. For details refer to
| the included gpl.txt file or visit http://gnu.org
+----------------------------------------------------*/
require_once "maincore.php";
include LOCALE.LOCALESET."print.php";
if (!isset($item_id) || !isNum($item_id)) fallback("index.php");
echo "<!DOCTYPE HTML PUBLIC '-//W3C//DTD HTML 4.01 Transitional//EN'
'http://www.w3.org/TR/html4/loose.dtd'>
<html>
<head>
<title>".$settings['sitename']."</title>
<meta http-equiv='Content-Type' content='text/html; charset=".$locale['charset']."'>
<style type=\"text/css\">
body { font-family:Verdana,Tahoma,Arial,Sans-Serif;font-size:14px; }
hr { height:1px;color:#ccc; }
.small { font-family:Verdana,Tahoma,Arial,Sans-Serif;font-size:12px; }
.small2 { font-family:Verdana,Tahoma,Arial,Sans-Serif;font-size:12px;color:#666; }
</style>
</head>
<body>\n";
if ($type == "A") {
$result = dbquery(
"SELECT ta.*,tac.*, tu.user_id,user_name FROM ".$db_prefix."articles ta
INNER JOIN ".$db_prefix."article_cats tac ON ta.article_cat=tac.article_cat_id
LEFT JOIN ".$db_prefix."users tu ON ta.article_name=tu.user_id
WHERE article_id='$item_id'"
);
$res = false;
if (dbrows($result)) {
$data = dbarray($result);
if (checkgroup($data['article_cat_access'])) {
$res = true;
$article = str_replace("<--PAGEBREAK-->", "", stripslashes($data['article_article']));
if ($data['article_breaks'] == "y") $article = nl2br($article);
echo "<b>".$data['article_subject']."</b><br>
<span class='small'>".$locale['400'].$data['user_name'].$locale['401'].ucfirst(showdate("longdate", $data['article_datestamp']))."</span>
<hr>
$article\n";
}
}
if (!$res) { fallback("index.php"); }
} elseif ($type == "N") {
$result = dbquery(
"SELECT tn.*, user_id, user_name FROM ".$db_prefix."news tn
LEFT JOIN ".$db_prefix."users tu ON tn.news_name=tu.user_id
WHERE news_id='$item_id'"
);
$res = false;
if (dbrows($result)) {
$data = dbarray($result);
if (checkgroup($data['news_visibility'])) {
$res = true;
$news = stripslashes($data['news_news']);
if ($data['news_breaks'] == "y") $news = nl2br($news);
if ($data['news_extended']) {
$news_extended = stripslashes($data['news_extended']);
if ($data['news_breaks'] == "y") $news_extended = nl2br($news_extended);
} else {
$news_extended = "";
}
}
echo "<b>".$data['news_subject']."</b><br>
<span class='small'>".$locale['400'].$data['user_name'].$locale['401'].ucfirst(showdate("longdate", $data['news_datestamp']))."</span>
<hr>
$news\n";
if ($news_extended) echo "<hr>\n<b>".$locale['402']."</b>\n<hr>\n$news_extended\n";
}
if (!$res) { fallback("index.php"); }
}
[b]// comment
$result = dbquery(
"SELECT tcm.*,user_name,user_id FROM ".DB_PREFIX."comments tcm
LEFT JOIN ".DB_PREFIX."users tcu ON tcm.comment_name=tcu.user_id
WHERE comment_item_id='".$item_id."' AND comment_type='".$type."'
ORDER BY comment_datestamp ASC"
);
if (dbrows($result) != 0) {
echo "<br><hr>\n<b>Komentarze</b>\n<hr>";
while ($data = dbarray($result)) {
echo "<b>Autor:</b> <a href='".BASEDIR."profile.php?lookup=".$data['user_id']."'>".$data['user_name']."</a><br><b>Komentarz:</b> ".$data['comment_message']."<br><br>";
}
}
[/b]
echo "</body>
</html>\n";
mysql_close();
ob_end_flush();
?>
Pozdro!! |
